Skip to content
This repository was archived by the owner on Jan 28, 2021. It is now read-only.
This repository was archived by the owner on Jan 28, 2021. It is now read-only.

isConnected not handling waitForACKResponse correctly #72

Closed
@matthewgkerr

Description

@matthewgkerr

isConnected is assuming sendCommand is returning zero for error, and non-zero for ok. However waitForACKResponse will return SFE_UBLOX_STATUS_DATA_SENT if the response was received, otherwise it could return some other zero or non-zero value. I think isConnected should be checking the return value of sendCommand for SFE_UBLOX_STATUS_DATA_SENT and return true, otherwise return false.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions