This repository was archived by the owner on Jan 28, 2021. It is now read-only.
This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Unnecessary reset of commandAck #35
Closed
Description
The first line of the function sendCommand sets the variable commandAck to false.
The end of the same function calls the function waitForResponse.
The first line of the function waitForResponse again sets the variable commandAck to false.
The variable commandAck will remain false until the function checkUblox is called, which is done in the function waitForResponse.
I think setting the variable commandAck in the function sendCommand can be removed.
I'm assuming the library is used in a single threaded application, and the serial Interrupt Service Routine is NOT calling checkUblox.
Am I correct in saying setting the variable commandAck in the function sendCommand is unnecessary, or am I missing something?
Metadata
Metadata
Assignees
Labels
No labels