Many fixes to handling continuous/multiple socket connections. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 16, 2020 11:01
…FOR FULL FUNCTIONALITY. DEVICE CURRENTLY SHIPS WITH OBSOLETE FIRMWARE. - Added 2056 byte read and backlog buffers (can probably be made smaller) - Added a 1000uS window on read operations from module (can probably be made smaller) - Increased memory allocation to response/command variables in various functions to avoid out of bound memory writes. - Added bufferedPoll(), this replaces poll() functionality, but iterates over buffer and handles each event - Added some error handling to socketOpen() - Added some error handling to socketCloser() - Added error handling to socketWrite(), to not write in case of error. - Added delay before responding in socketWrite(), according to ublox specification - Added socketWriteUDP() function, to properly write UDP packets according to ublox spec. - Added error catching to socketRead() - Added socketGetLastError() function that requests last socket error from module, for debugging - Added expectedError parameter to waitForResponse() to allow function to exit without error without running entire timeout if it can - Added backlog buffering to waitForResponse() - Added backlog pruning to waitForResponse() - Improved error codes returned from waitForResponse() - Added backlog buffering and pruning to sendCommandWithResponse() - Added backlog buffering to sendCommand - Removed code that dumped read data in send command - Created function pruneBacklog() that parses backlog and prunes non-actionable events, reducing future processing time in poll, and reducing buffer size needs. - Added value to error enumeration to signify when module has returned an error from a command.
…ted rough stack of code to listen for UDP packets. Still needs some cleanup.
PaulZC
added a commit
to sparkfun/SparkFun_u-blox_SARA-R5_Arduino_Library
that referenced
this pull request
Oct 21, 2020
Adding in @MatthewMenze 's PR: sparkfun/SparkFun_LTE_Shield_Arduino_Library#8 Thank you Matthew!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…FOR FULL FUNCTIONALITY. DEVICE CURRENTLY SHIPS WITH OBSOLETE FIRMWARE.