Fails to compile on Pico boards

[snarfattack]

This is just the first error of 8 when compiling, but they are all about the same readRegisterRegion function.

When using board "Arduino Mbed OS RP2040 Boards" I get this error:
...\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp:95:97: error: cannot bind non-const lvalue reference of type 'size_t& {aka unsigned int&}' to an rvalue of type 'size_t {aka unsigned int}'
sfeTkError_t result = _theBus->readRegisterRegion(kSfeAS7331RegCfgCreg1, regs, 6U, nRead);

When using board "Rasberry PI Pico/RP2040" I get this error:
...\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp:95:92: error: cannot bind non-const lvalue reference of type 'size_t&' {aka 'unsigned int&'} to a value of type 'uint32_t' {aka 'long unsigned int'}
95 | sfeTkError_t result = _theBus->readRegisterRegion(kSfeAS7331RegCfgCreg1, regs, 6U, nRead);

[SFE-Brudnerd]

Hi @snarfattack I'm taking a look at this. Just a couple quick questions to help me out.

1. Which version of the library are you working with?
2. Which Arduino Core and which version of the Arduino core are you working with?
3. Do you have sample code that you were running this on, or was this just a blank sketch?

[snarfattack]

1. v2.1.0, installed through the Arduino IDE Library Manager
2. For Arduino Mbed OS RP2040 Boards, v4.0.10, and for Raspberry Pi Pico/RP2040, v3.6.2
3. I used your example01

Full compiler output from the Raspberry Pi Pico/RP2040 board:

d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp: In member function 'bool SfeAS7331Driver::runDefaultSetup(const bool&)':
d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp:95:92: error: cannot bind non-const lvalue reference of type 'size_t&' {aka 'unsigned int&'} to a value of type 'uint32_t' {aka 'long unsigned int'}
   95 |         sfeTkError_t result = _theBus->readRegisterRegion(kSfeAS7331RegCfgCreg1, regs, 6U, nRead);
      |                                                                                            ^~~~~
In file included from d:\Users\User\Documents\Arduino\libraries\SparkFun_Toolkit\src/sfeTk/sfeTkII2C.h:29,
                 from d:\Users\User\Documents\Arduino\libraries\SparkFun_Toolkit\src/sfeTkArdI2C.h:34,
                 from d:\Users\User\Documents\Arduino\libraries\SparkFun_Toolkit\src/SparkFun_Toolkit.h:36,
                 from d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.h:28,
                 from d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp:1:
d:\Users\User\Documents\Arduino\libraries\SparkFun_Toolkit\src/sfeTk/sfeTkIBus.h:126:98: note:   initializing argument 4 of 'virtual sfeTkError_t sfeTkIBus::readRegisterRegion(uint8_t, uint8_t*, size_t, size_t&)'
  126 |     virtual sfeTkError_t readRegisterRegion(uint8_t reg, uint8_t *data, size_t numBytes, size_t &readBytes) = 0;
      |                                                                                          ~~~~~~~~^~~~~~~~~
d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp: In member function 'sfeTkError_t SfeAS7331Driver::readAllUV()':
d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp:269:92: error: cannot bind non-const lvalue reference of type 'size_t&' {aka 'unsigned int&'} to a value of type 'uint32_t' {aka 'long unsigned int'}
  269 |     sfeTkError_t result = _theBus->readRegisterRegion(kSfeAS7331RegMeasMres1, dataRaw, 6U, nRead);
      |                                                                                            ^~~~~
d:\Users\User\Documents\Arduino\libraries\SparkFun_Toolkit\src/sfeTk/sfeTkIBus.h:126:98: note:   initializing argument 4 of 'virtual sfeTkError_t sfeTkIBus::readRegisterRegion(uint8_t, uint8_t*, size_t, size_t&)'
  126 |     virtual sfeTkError_t readRegisterRegion(uint8_t reg, uint8_t *data, size_t numBytes, size_t &readBytes) = 0;
      |                                                                                          ~~~~~~~~^~~~~~~~~
d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp: In member function 'sfeTkError_t SfeAS7331Driver::readAll()':
d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp:314:91: error: cannot bind non-const lvalue reference of type 'size_t&' {aka 'unsigned int&'} to a value of type 'uint32_t' {aka 'long unsigned int'}
  314 |     sfeTkError_t result = _theBus->readRegisterRegion(kSfeAS7331RegMeasTemp, dataRaw, 8U, nRead);
      |                                                                                           ^~~~~
d:\Users\User\Documents\Arduino\libraries\SparkFun_Toolkit\src/sfeTk/sfeTkIBus.h:126:98: note:   initializing argument 4 of 'virtual sfeTkError_t sfeTkIBus::readRegisterRegion(uint8_t, uint8_t*, size_t, size_t&)'
  126 |     virtual sfeTkError_t readRegisterRegion(uint8_t reg, uint8_t *data, size_t numBytes, size_t &readBytes) = 0;
      |                                                                                          ~~~~~~~~^~~~~~~~~
d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp: In member function 'sfeTkError_t SfeAS7331Driver::readOutConv()':
d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src\sfeAS7331.cpp:363:96: error: cannot bind non-const lvalue reference of type 'size_t&' {aka 'unsigned int&'} to a value of type 'uint32_t' {aka 'long unsigned int'}
  363 |     sfeTkError_t result = _theBus->readRegisterRegion(kSfeAS7331RegMeasOutConvL, tconvRaw, 4U, nRead);
      |                                                                                                ^~~~~
d:\Users\User\Documents\Arduino\libraries\SparkFun_Toolkit\src/sfeTk/sfeTkIBus.h:126:98: note:   initializing argument 4 of 'virtual sfeTkError_t sfeTkIBus::readRegisterRegion(uint8_t, uint8_t*, size_t, size_t&)'
  126 |     virtual sfeTkError_t readRegisterRegion(uint8_t reg, uint8_t *data, size_t numBytes, size_t &readBytes) = 0;
      |                                                                                          ~~~~~~~~^~~~~~~~~

exit status 1

Compilation error: exit status 1

[snarfattack]

Hmm, I assumed it was only on pico boards, but I have similar errors on the Arduino Uno... I changed the SparkFun Toolkit from version 0.9.0, to 0.8.0, and I get the following error instead now:

In file included from C:\Users\User\AppData\Local\Temp\.arduinoIDE-unsaved202402-9992-10zey7j.cyi5\sketch_jan2b\sketch_jan2b.ino:27:
d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src/SparkFun_AS7331.h: In member function 'bool SfeAS7331ArdI2C::begin(const uint8_t&, TwoWire&)':
d:\Users\User\Documents\Arduino\libraries\SparkFun_AS7331_Arduino_Library\src/SparkFun_AS7331.h:46:20: error: 'class sfeTkArdI2C' has no member named 'setStop'
   46 |         _theI2CBus.setStop(false);
      |                    ^~~~~~~

exit status 1

Compilation error: exit status 1

[SFE-Brudnerd]

@snarfattack would you mind confirming that branch fix#4 works for you? Seems like when we revved the Toolkit library and made the variables size_t instead of uint32_t, I forgot to update a few key things. It didn't show up in my testing on ESP32/STM32, must be something with difference in architecture. Thanks for catching that!

[snarfattack]

It compiled, and using your Example 1, pointed out the window to get low UVA values, 0's for B and C. Used my UV flashlight to confirm high values for UVA and low values for B, and C. All as expected. Thanks!

[SFE-Brudnerd]

Great, I'll get that packaged up and push a release!