Software serial #48
Merged
Software serial #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to dispose of the ugly global table of pointers to software serial objects. Instead those pointers are all handled in the GPIO core. We will need to make sure to detach the interrupt (and thereby remove reference to the software serial object) when the object is destroyed.
This makes it so that only one software serial object can work at any give time, right? How can we handle multiple objects at once?
|
@nseidle You're right that 11, 48, and 49 are affected -- additionally pad 37 uses 'REG_CTIMER_INCFG' set to 7 by default so it is affected as well. OTTOMH I can't see a way to move any of these pads to another default because they are already used by other pads. |
|
Awesome. Thanks for checking that. FYI - I updated the notes on the library files and pushed to master the following: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoftwareSerial v1.0 is ready. I'm happy with the performance.
Limitations (similar to SoftwareSerial built into standard Arduino core):
I believe pads 11, 48, and 49 are disabled when we take over CMPR7. 48 and 49 are used as an actual UART so really only pad 11 is disrupted.
@oclyke - WRT pads loosing PWM capabilities: I remember you mentioned table 818 had a few duplicate outputs that perhaps you had programmed around? I don't see any other pads that are A7OUTB or whatever but realized you may have used output selection 3 on some pads. Please let me know if you pulled in a #7 pad and I'll add the note to 'does not work with pads 11, or X'.