Corrected the pads for SDA2 and SCL2 on the Nano #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulZC
changed the title
|
Looks like a good fix to me! The reason the port still works is because the default Wire port gets associated with IOMaster 2, and the IOMaster peripherals don't have pin multiplexing. The fact that these were wrong would have only been discovered if someone tried to use the Qwiic pins directly, but that is unlikely. Anyway thanks a bunch for spotting that! |
|
Cheers Owen - all the best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Nathan (@nseidle ) / Owen (@oclyke),
I noticed a gremlin in the pin to pad mappings for the Artemis Nano. Pads 32 and 12 were allocated twice:
https://github.com/sparkfun/Arduino_Apollo3/blob/master/variants/redboard_artemis_nano/config/variant.cpp#L43-L46
Please check if this PR is valid, because (a) I don't have a Nano and (b) surely this means the Nano Qwiic port doesn't work at the moment?
Cheers,
Paul