Skip to content

Digital w after analog fix #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Digital w after analog fix #148

merged 3 commits into from
Apr 15, 2020

Conversation

Wenn0101
Copy link
Contributor

Add a check in digital write to see if the pin is not longer configured for GPIO, and change it back if needed.

This allows a DigitalWrite to follow an AnalogWrite, which is consistent with the behavior some user may expect.

@Wenn0101 Wenn0101 requested review from nseidle and oclyke April 10, 2020 04:15
Copy link
Contributor

@oclyke oclyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Whether or not to accept PR is a matter of core style / API faithfulness. I think we should all have our own say first.

Little note about committing whitespace changes individually.

leaving the ap3_get_funct_sel function for future utility
@oclyke oclyke merged commit 11cc17a into master Apr 15, 2020
@oclyke oclyke deleted the DigitalW_after_analog_fix branch April 15, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants