Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

clarify GitHub ext svc docs, standardize on terms #2952

Merged
merged 1 commit into from
Mar 23, 2019
Merged

clarify GitHub ext svc docs, standardize on terms #2952

merged 1 commit into from
Mar 23, 2019

Conversation

sqs
Copy link
Member

@sqs sqs commented Mar 23, 2019

@sqs sqs requested a review from felixfbecker as a code owner March 23, 2019 15:59
@sqs sqs mentioned this pull request Mar 23, 2019
Closed
@sqs
clarify GitHub ext svc docs, standardize on terms
ca081d6 
- fix #2946 by implying that no "repo" scope is needed in the example JSON and explicitly mentioning it in the JSON Schema docs (the explicit mention is omitted from the example JSON for brevity, so that the "token" property is above the fold on an average-sized screen)
- use "repository" not "repo" per https://docs.sourcegraph.com/dev/style_guide
@sqs sqs requested review from KattMingMing and removed request for felixfbecker March 23, 2019 16:08
KattMingMing
KattMingMing approved these changes Mar 23, 2019
View reviewed changes
Copy link
Contributor

@KattMingMing KattMingMing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@sqs sqs merged commit d2b0714 into master Mar 23, 2019
@sqs sqs deleted the gh-token-url branch March 23, 2019 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KattMingMing KattMingMing KattMingMing approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify usage of GitHub repos w/o repo-scope access token
2 participants
@sqs @KattMingMing