Skip to content

Emit enclosing ranges for declarations #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Emit enclosing ranges for declarations #308

merged 10 commits into from
Jan 9, 2024

Conversation

varungandhi-src
Copy link
Contributor

@varungandhi-src varungandhi-src commented Dec 25, 2023

Based on #293, but created a separate PR since I couldn't push
to that branch. The following declarations have enclosing ranges:

TODOs

  • Do some basic benchmarking to see if this has a noticeable effect on runtime. If so, we should put it behind a feature flag. -- Measured against sourcegraph/sourcegraph, no noticeable difference in perf averaged over 10 runs.

Test plan

Covered by newly added snapshot tests.

@varungandhi-src varungandhi-src changed the title Adds support for enclosing_ranges to scip-typescript Adds support for enclosing ranges Dec 25, 2023
@varungandhi-src varungandhi-src requested review from kritzcreek and removed request for kritzcreek December 25, 2023 14:10
@varungandhi-src varungandhi-src changed the title Adds support for enclosing ranges Emit enclosing ranges for declarations Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants