Skip to content

test: Re-use snapshot formatting from scip-python #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 25, 2023

Conversation

varungandhi-src
Copy link
Contributor

@varungandhi-src varungandhi-src commented Dec 25, 2023

The feature implementation PR #293 changes the snapshot formatting for a large
number of snapshots, making it harder to verify that there are no unexpected
changes due to the changes in the code. This patch separates out the
snapshot formatting so that it is clearer what the mapping from
code changes -> snapshot output changes is.

Test plan

Covered by existing snapshot tests

Co-authored-by: Titouan Launay <titouan.launay@lleedpartners.com>
@varungandhi-src
Copy link
Contributor Author

cc @Titou325

@varungandhi-src varungandhi-src merged commit c22c95c into main Dec 25, 2023
@varungandhi-src varungandhi-src deleted the vg/update-snapshots branch December 25, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants