Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

feat(typescript): upgrade to typescript 2.8.3 #452

Merged
merged 1 commit into from
May 8, 2018
Merged

feat(typescript): upgrade to typescript 2.8.3 #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
"rxjs": "^5.5.0",
"semaphore-async-await": "^1.5.1",
"string-similarity": "^1.1.0",
"typescript": "2.7.2",
"typescript": "2.8.3",
"vscode-jsonrpc": "^3.3.1",
"vscode-languageserver": "^3.1.0",
"vscode-languageserver-types": "^3.0.3"
Expand Down
3 changes: 2 additions & 1 deletion src/diagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ function convertDiagnosticCategory(category: ts.DiagnosticCategory): DiagnosticS
return DiagnosticSeverity.Warning
case ts.DiagnosticCategory.Message:
return DiagnosticSeverity.Information
// unmapped: DiagnosticSeverity.Hint
case ts.DiagnosticCategory.Suggestion:
return DiagnosticSeverity.Hint
}
}
12 changes: 6 additions & 6 deletions src/test/typescript-service-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2297,11 +2297,11 @@ export function describeTypeScriptService(
uri: 'git://github.com/Microsoft/TypeScript?v' + ts.version + '#lib/lib.dom.d.ts',
range: {
start: {
line: 8446,
line: 9378,
character: 10,
},
end: {
line: 8446,
line: 9378,
character: 14,
},
},
Expand All @@ -2310,11 +2310,11 @@ export function describeTypeScriptService(
uri: 'git://github.com/Microsoft/TypeScript?v' + ts.version + '#lib/lib.dom.d.ts',
range: {
start: {
line: 8498,
line: 9429,
character: 12,
},
end: {
line: 8498,
line: 9429,
character: 16,
},
},
Expand Down Expand Up @@ -3309,8 +3309,8 @@ export function describeTypeScriptService(
fileName: toUnixPath(uri2path(rootUri + 'a.ts')), // path only used by TS service
textChanges: [
{
span: { start: 49, length: 13 },
newText: '\t\tthis.missingThis',
span: { start: 51, length: 11 },
newText: 'this.missingThis',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like tabs are not anymore captured

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine since start is excluding the tabs

},
],
},
Expand Down