This repository was archived by the owner on Oct 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 73
Fix global type loading on Windows paths #362
Merged
felixfbecker
merged 10 commits into
sourcegraph:master
from
tomv564:fix-global-types-on-windows
Oct 9, 2017
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7f57e21
fix: use unixPath for matching windows paths to configuration paths
tomv564 f0c8e02
fix: Normalise typeRoots and filePath used against config checks to f…
96d6c47
fix: Add tests, handle windows paths in project-manager
tomv564 6d9d3d0
fix: Make typeRoot test more thorough, add global declaration test
tomv564 68c596b
fix: Put per-path test scenario inline
tomv564 0e0b099
fix: Use string.search instead of includes + lastIndexOf
tomv564 703d664
fix: Annotate classes and functions that convert paths to forward sla…
tomv564 34f0c5d
fix: Add note about ProjectManager using Windows paths
tomv564 738b475
Merge branch 'master' into fix-global-types-on-windows
felixfbecker 5fc67b6
fix: Use CONSTANT_CASE for module constant
tomv564 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use
string.search()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely more compact:
Do you prefer this? If so, I propose storing the regex as a static member somewhere (or adding this functionality to
util.ts
.