This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Update sinon to the latest version 🚀 #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #358 +/- ##
==========================================
+ Coverage 74.56% 76.16% +1.59%
==========================================
Files 14 14
Lines 1671 1888 +217
Branches 313 360 +47
==========================================
+ Hits 1246 1438 +192
- Misses 279 294 +15
- Partials 146 156 +10
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 4.0.0 of sinon just got published.
The version 4.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of sinon.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 11 commits.
95908f4Add release notes for 4.0.0460907bUpdate docs/changelog.md and set new release id in docs/_config.yml6f599a6Add release documentation for v4.0.0fba2e294.0.0c838e22Update History.md and AUTHORS for new release3837635Merge pull request #1569 from fatso83/1566-update-deps3d3a044Explicitly update fake xhr lib 'nise'5ec0ae0Merge pull request #1564 from fatso83/amended-1563cf32e6dUpdate deps lock file37ff38bRemoves dependency to "build"34fc2baRemove support for stubbing undefined props (#1557)See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴