feat(typescript): upgrade to typescript 2.8.3 #452

matthiaskern · 2018-05-02T16:07:55Z

There are some some tests failing due to code location in lib.ts files, are those safe to fix? #448

matthiaskern · 2018-05-02T16:08:31Z

src/diagnostics.ts

@@ -27,14 +27,16 @@ export function convertTsDiagnostic(diagnostic: ts.Diagnostic): Diagnostic {
 *
 * @param category The Typescript DiagnosticCategory
 */
-function convertDiagnosticCategory(category: ts.DiagnosticCategory): DiagnosticSeverity {
+function convertDiagnosticCategory(category: ts.DiagnosticCategory): DiagnosticSeverity | undefined {


Had to add a default case due to
TS2366: Function lacks ending return statement and return type does not include 'undefined'

felixfbecker · 2018-05-02T18:54:56Z

package.json

@@ -51,7 +51,7 @@
    "rxjs": "^5.5.0",
    "semaphore-async-await": "^1.5.1",
    "string-similarity": "^1.1.0",
-    "typescript": "2.7.2",
+    "typescript": "^2.8.3",


Please pin this version, any version change can break.

felixfbecker · 2018-05-02T19:49:37Z

src/diagnostics.ts

    switch (category) {
        case ts.DiagnosticCategory.Error:
            return DiagnosticSeverity.Error
        case ts.DiagnosticCategory.Warning:
            return DiagnosticSeverity.Warning
        case ts.DiagnosticCategory.Message:
            return DiagnosticSeverity.Information
+        default:


This shouldn't have a default, the fact that TS will error if not all DiagnosticSeverities are handled is a good thing. This should instead handle the new DiagnosticSeverity. This should map to Hint

felixfbecker · 2018-05-02T19:50:07Z

Yes, the locations in the tests need to be updated.

codecov · 2018-05-03T10:42:16Z

Codecov Report

Merging #452 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #452      +/-   ##
=========================================
- Coverage   83.18%   83.1%   -0.09%     
=========================================
  Files          15      15              
  Lines        2040    2042       +2     
  Branches      482     416      -66     
=========================================
  Hits         1697    1697              
- Misses        341     343       +2     
  Partials        2       2

Impacted Files	Coverage Δ
src/diagnostics.ts	`68.42% <0%> (-8.05%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b0140...d32e5ee. Read the comment docs.

matthiaskern · 2018-05-03T10:48:57Z

src/test/typescript-service-helpers.ts

-                                    span: { start: 49, length: 13 },
-                                    newText: '\t\tthis.missingThis',
+                                    span: { start: 51, length: 11 },
+                                    newText: 'this.missingThis',


Seems like tabs are not anymore captured

That's fine since start is excluding the tabs

felixfbecker · 2018-05-03T18:51:31Z

src/diagnostics.ts

@@ -35,6 +35,7 @@ function convertDiagnosticCategory(category: ts.DiagnosticCategory): DiagnosticS
            return DiagnosticSeverity.Warning
        case ts.DiagnosticCategory.Message:
            return DiagnosticSeverity.Information
-        // unmapped: DiagnosticSeverity.Hint
+        default:


as said, there shouldn't be a default case, the new ts.DiagnosticSeverity.Suggestion that was introduced and caused this error should be mapped explicitely. Otherwise we won't get errors like this for future updates.

whoops, I misunderstood. Should the new ts.DiagnosticCategory.Suggestion be mapped to DiagnosticSeverity.Hint then?

I would think so? Semantically the words seem similar

Examples for Suggestion: https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/Microsoft/TypeScript%24+Suggestion+f:%5Esrc/compiler/diagnosticMessages.json%24

Examples for Message: https://sourcegraph.com/search?q=repo:%5Egithub%5C.com/Microsoft/TypeScript%24+Message+f:%5Esrc/compiler/diagnosticMessages.json%24

Maybe check if a Hint is properly displayed by your client (VS Code, neovim, VS Code, ...)?

Checked with neovim. Also agree it makes the most sense semantically.

felixfbecker · 2018-05-03T18:54:25Z

Didn't mean to approve yet

felixfbecker

Almost good to go, but looks like you used npm 5 to install which changed the whole lockfile - please make sure to use npm 6

matthiaskern · 2018-05-08T10:50:32Z

Not sure what am I missing. Regenerated with v6 but it still seems to have changed a ton? Maybe just a dependency's fault.

tsirlucas · 2018-05-08T18:26:36Z

Hey @felixfbecker, please answer this once the new version is up so I can enable the vscode plugin again haha

felixfbecker · 2018-05-08T18:30:34Z

@tsirlucas I am not an RSS feed, you can watch the build yourself 😉 https://travis-ci.org/sourcegraph/javascript-typescript-langserver/builds/376491759

tsirlucas · 2018-05-08T18:33:29Z

Oh, that's not what I meant! I was afraid that the release to the vscode market would be manual or something. Really sorry if I sounded like an ass. :(

felixfbecker · 2018-05-08T18:34:10Z

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

felixfbecker · 2018-05-08T18:49:33Z

@tsirlucas it is, but there are still other services to subscribe for new releases 😉 . No offense taken though

felixfbecker · 2018-05-08T18:58:35Z

@tsirlucas having some problems with vsce access tokens, can't update the extension rn. Sorry.

tsirlucas · 2018-05-08T18:59:53Z

No need to apologize lol

Can you give me the url of some of that services you told me about so I can subscribe for the release?

felixfbecker · 2018-05-08T19:05:19Z

I use Sibbell which is being shut down soon, but a simple Google search brings up https://coderelease.io/

tsirlucas · 2018-05-08T19:06:06Z

@felixfbecker Thanks!

matthiaskern commented May 2, 2018

View reviewed changes

felixfbecker reviewed May 2, 2018

View reviewed changes

matthiaskern force-pushed the typescript-2.8.3 branch 2 times, most recently from b085afd to c4e74fe Compare May 3, 2018 10:36

matthiaskern commented May 3, 2018

View reviewed changes

felixfbecker reviewed May 3, 2018

View reviewed changes

felixfbecker approved these changes May 3, 2018

View reviewed changes

matthiaskern force-pushed the typescript-2.8.3 branch 3 times, most recently from 260a38b to 39119a2 Compare May 6, 2018 19:11

felixfbecker suggested changes May 8, 2018

View reviewed changes

matthiaskern force-pushed the typescript-2.8.3 branch 3 times, most recently from 2195211 to a0164c2 Compare May 8, 2018 10:48

feat(typescript): upgrade to typescript 2.8.3

d32e5ee

felixfbecker force-pushed the typescript-2.8.3 branch from a0164c2 to d32e5ee Compare May 8, 2018 18:18

felixfbecker approved these changes May 8, 2018

View reviewed changes

felixfbecker merged commit 15579a1 into sourcegraph:master May 8, 2018

feat(typescript): upgrade to typescript 2.8.3 #452

feat(typescript): upgrade to typescript 2.8.3 #452

Uh oh!

Conversation

matthiaskern commented May 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felixfbecker commented May 2, 2018

Uh oh!

codecov bot commented May 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felixfbecker commented May 3, 2018

Uh oh!

felixfbecker left a comment

Choose a reason for hiding this comment

Uh oh!

matthiaskern commented May 8, 2018

Uh oh!

tsirlucas commented May 8, 2018

Uh oh!

felixfbecker commented May 8, 2018

Uh oh!

tsirlucas commented May 8, 2018

Uh oh!

felixfbecker commented May 8, 2018

Uh oh!

felixfbecker commented May 8, 2018

Uh oh!

felixfbecker commented May 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsirlucas commented May 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

felixfbecker commented May 8, 2018

Uh oh!

tsirlucas commented May 8, 2018

Uh oh!

Uh oh!

matthiaskern commented May 2, 2018 •

edited

Loading

codecov bot commented May 3, 2018 •

edited

Loading

felixfbecker commented May 8, 2018 •

edited

Loading

tsirlucas commented May 8, 2018 •

edited

Loading