rename also changes unrelated files

[mickaelistria]

With version 2.0.pre30. I'm opening a basic var a = 0; test.js file, and ask for a rename on a. The response include some changes to an entirely unrelated file: file:///home/mistria/git/eclipse-bluesky/org.eclipse.bluesky/language-servers/node_modules/typescript/lib/lib.d.ts which is not in the same folder nor in the hierarchy.
I have the impression that 2 instances of the jsts-ls are started and use the same backend for file state, and assumes both projects are linked. If so, what could be a solution to guarantee some level of isolation? I believe the 2 connections are already specifying different rootUris.

[felixfbecker]

Could you clarify what URI the test.js file has?

[mickaelistria]

URI of the file is file:///home/mistria/runtime-EclipseApplication/project/test.js , initialize message sets

    "rootPath": "/home/mistria/runtime-EclipseApplication/project",
    "rootUri": "file:///home/mistria/runtime-EclipseApplication/project/",

[felixfbecker]

I think this is because we always add the TypeScript lib.d.ts files and if you create a file without an import or export statement, it is in the global scope and any identifier in the global scope matching a will get renamed. Could you show what exactly gets renamed in lib.d.ts to confirm my suspicion?

I think the best fix would be to never rename anything in node_modules as changing a dependency is certainly always unintentional.

[mickaelistria]

Could you show what exactly gets renamed in lib.d.ts to confirm my

suspicion? The list is extremely long, here are the few last occurences: ```js { "range": { "start": { "line": 19565, "character": 24 }, "end": { "line": 19565, "character": 25 } }, "newText": "newName" }, { "range": { "start": { "line": 19579, "character": 48 }, "end": { "line": 19579, "character": 49 } }, "newText": "newName" }, { "range": { "start": { "line": 19585, "character": 47 }, "end": { "line": 19585, "character": 48 } }, "newText": "newName" }, { "range": { "start": { "line": 19591, "character": 15 }, "end": { "line": 19591, "character": 16 } }, "newText": "newName" } ], ```

I think the best fix would be to never rename anything in node_modules as

changing a dependency is certainly always unintentional. Probably, but in this case, I have the impression the best fix would be to ignore all files that aren't children of the same rootUri.