Skip to content

Update Dockerfile 21.11.3 #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Update Dockerfile 21.11.3 #287

merged 2 commits into from
Dec 21, 2021

Conversation

reddexx
Copy link
Contributor

@reddexx reddexx commented Dec 15, 2021

No description provided.

@solidnerd
Copy link
Owner

Hey @reddexx,
thanks for the contribution lets have the build running and I'll merge it.

@reddexx
Copy link
Contributor Author

reddexx commented Dec 21, 2021

@solidnerd the test failed, the error can ignore?

@solidnerd
Copy link
Owner

@reddexx Something has changed the bookstack app is not starting

wait-for-db: waiting for mysql:3306
wait-for-db: done
Generating Key...

In Request.php line 334:

  Symfony\Component\HttpFoundation\Request::create(): Argument #1 ($uri) must
   be of type string, null given, called in /var/www/bookstack/vendor/laravel
  /framework/src/Illuminate/Foundation/Bootstrap/SetRequestForConsole.php on
  line 32

@solidnerd
Copy link
Owner

Okay got it APP_URL needs to be specified

APP_URL=http://localhost:${DEV_PORT:-8080}

@reddexx
Copy link
Contributor Author

reddexx commented Dec 21, 2021

Can you Change this?

@solidnerd
Copy link
Owner

Already done 👍 waiting for rerun 💯

@solidnerd
Copy link
Owner

@reddexx Thanks for your contribution. 💯 I'm gonna merge this

@solidnerd solidnerd merged commit ab3857a into solidnerd:master Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants