Skip to content

Made BookStack uploads folder volumable #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Made BookStack uploads folder volumable #2

merged 1 commit into from
Aug 26, 2016

Conversation

ssddanbrown
Copy link
Contributor

Thought it would be a good idea to make the uploads folder into a volume so that they can persist like the MySQL data. This makes them easier to back up and it also becomes easier to share the uploads between multiple BookStack docker instances (Not a common requirement but it's fun to see in action). Unfortunately this does require forcing permissions on the upload folder every startup, Hence the entrypoint script change.

I'm not sure how this affects your docker image versioning (I've never published docker images). If it helps I'm likely to be releasing another BookStack bugfix release this weekend which will bump BookStack to version v0.11.2 so this could be merged with that version change if it makes things easier.

@solidnerd
Copy link
Owner

solidnerd commented Aug 20, 2016

I really appreciate your work on the image 👍 . Currently I can't say how much impact this will have. The mounting of a volume causes the issue with permissions. I will try to improve this later on the weekend ( I hope that i can afford the time). My next improvement that are planed are:

  • switch to alpine
  • reduce layers
  • use NGINX instead of apache ( I more familiar with NGINX this will require a supervisor) (Probably support both)
  • Improve entrypoint script
  • Better Logs
  • Add more environment variables
    • UID / GUID Mappings
    • User
  • better configuration support through config substitution (Configuration variables accessible via env's)

If you think features will be missing add an issue for that.

@solidnerd
Copy link
Owner

Sorry for the delay I will merge this now.

@solidnerd solidnerd merged commit 653ccb1 into solidnerd:master Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants