Skip to content

remove hardcoded ldap libdir in Dockerfile #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2018
Merged

remove hardcoded ldap libdir in Dockerfile #109

merged 1 commit into from
Dec 29, 2018

Conversation

BeckerFelix
Copy link
Contributor

I found this repo to be regularly updated (thank you!) and thus I am using it to host a bookstack container on raspberry pi. For this purpose, I am rebuilding the image on the device with the Dockerfile provided. It works flawless despite one line:

&& docker-php-ext-configure ldap --with-libdir=lib/x86_64-linux-gnu/ \

Obviously, the path lib/x86_64-linux-gnu does not exist on arm architecture. Removing the argument results in a successful build both on arm as well as amd64 systems.
As far as I see, the argument can be omitted to gain compatibility for arm. Let me know if I am missing anything.

@solidnerd
Copy link
Owner

Hey @MilkWithCoffee,

thanks for your pull request. I can't see any problems with this. Also all the checks have passed through the ci so we can integrate.

I'll merge it and it will be in the next release.

@solidnerd solidnerd merged commit 0e9a42e into solidnerd:master Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants