Skip to content

fix: resolve #254: handle closing sockets upon on_fail events #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 8, 2021
Merged

fix: resolve #254: handle closing sockets upon on_fail events #290

merged 2 commits into from
Feb 8, 2021

Conversation

AdrianDC
Copy link
Contributor

@AdrianDC AdrianDC commented Feb 5, 2021 •
edited
Loading

Closes #254

@darrachequesne darrachequesne merged commit e7de4eb into socketio:master Feb 8, 2021
@darrachequesne
Copy link
Member

@AdrianDC thanks!

@AdrianDC AdrianDC deleted the 254 branch February 22, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sio::client destructor stuck indefinitely
2 participants
@AdrianDC @darrachequesne