-
Notifications
You must be signed in to change notification settings - Fork 0
[CLIENT] [COMPONENT] : Navigation bar in application #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…gation component complete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good overall — just a small UI detail to point out:
When we are in the root path (/), the Home tab in the navigation bar should be active. Currently, it's only active when the path is /home.
Current Behavior:
Expected Behavior:
Not a major issue, but thought I’d flag it for polish. Great work otherwise!
Damn brother, thats one of the best replied comments I have ever gotten ! And thanks for the attention to detail. I will fix this ASAP ! 🍾 |
The required changes are done @h4jack ! Thanks for the feedback man ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just look into it .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
PULL REQUEST SUMMARY
This feature includes developing the navigation bar component for the application
FILES THAT ARE WORKED ON
client/index.html
yes
yes
client/src/App.tsx
yes
yes
src/NavigationBar.tsx
no
yes
src/Navigation.styles.css
no
yes
src/Layout.tsx
no
yes
src/NavigationLinks.ts
no
yes
src/NavigationLinks.types.ts
no
yes
client/src/global.css
yes
yes
client/Logo.tsx
no
yes
client/Logo.types.tsx
no
yes
client/Loader.tsx
no
yes
client/Loader.styles.css
no
yes
ANY ISSUES WORKED ON
#6
PROVIDE EVIDANCE OF WORK
Screen.Recording.2025-05-24.at.11.12.05.PM.mov
OWNERSHIP
I confirm that I am responsible for this pull request
yes
ACCEPTANCE OF MY WORK
I have worked on all the acceptance criteria
yes
GIT FOLLOW UPS
git pull main
Checkout to the main branch, this will up-to-date your local with remote
git merge origin/main
Merges all the up-to-date changes of your local main to local feature branch