Add panic propagation #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... It is a bit annoying that it works differently with and without the feature flags. I think it would be possible to use the builder to allow users to explicitly opt-in to this behavior, but given that the current behavior is somewhat odd, I'm not clear that that is a good idea. |
Good idea, just to make sure no one is surprised by the new behavior. I've rebased on |
Merged
notgull
added a commit
to smol-rs/async-executor
that referenced
this pull request
Nov 17, 2023
After smol-rs/async-task#37 I meant to add this to the executor. This commit makes it so all panics are surfaced in the tasks that the user calls. Hopefully this improves ergonomics. Signed-off-by: John Nunley <dev@notgull.net>
fogti
pushed a commit
to smol-rs/async-executor
that referenced
this pull request
Nov 21, 2023
After smol-rs/async-task#37 I meant to add this to the executor. This commit makes it so all panics are surfaced in the tasks that the user calls. Hopefully this improves ergonomics. Signed-off-by: John Nunley <dev@notgull.net> Signed-off-by: Alain Zscheile <fogti+devel@ytrizja.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #36 by making it so, when the
stdfeature is enabled, panics are caught and then propagated when theTaskis polled. This generally makes more sense than whatever thread polling theRunnablepanicking.I had to adjust some tests which seemed to assume that the
Runnablepanics rather than theTask, I'm not sure whether this is an intended feature I'm overwriting or not.