fix(ESM package): QueryComplexity import CJS module from GraphQL #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for investigating and fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #75
The conflict on the bi-module support of QueryComplexity and graphql has caused the issue. For now if user use ESM, it will load ESM build of query complexity package. But this line of code will load commonjs module of graphql instead of ESM as expected. And it cause the issue that's been mentioned in #75.
The approach here is to allow user's compiler/transpiler decide it should load commonjs or ESM when it reach this line of code: https://github.com/slicknode/graphql-query-complexity/blob/master/src/QueryComplexity.ts#L11-L12.
This can be replaced by import specified extensions once both QueryComplexity and graphql are fully ESM.