Skip to content

Increase log access buffer to 8192 #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Increase log access buffer to 8192 #139

wants to merge 2 commits into from

Conversation

nickschuch
Copy link
Contributor

@nickschuch nickschuch commented Aug 27, 2024 •
edited
Loading

kimpepper
kimpepper reviewed Aug 27, 2024
View reviewed changes
packages/php8.2/fpm-log-buffer.patch
#include "zlog.h"

-#ifdef MAX_LINE_LENGTH
-# define FPM_LOG_BUFFER MAX_LINE_LENGTH
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we just set MAX_LINE_LENGTH ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on that too. Planning to test out both options in 2 separate PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the other PR where I'm doing testing:

#140

@nickschuch
Copy link
Contributor Author

This was superseded by: #140

@nickschuch nickschuch closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimpepper kimpepper kimpepper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickschuch @kimpepper