-
Notifications
You must be signed in to change notification settings - Fork 384
Update Control Plane links #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe recent updates focus on changing URLs from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .controlplane/readme.md (2 hunks)
- README.md (1 hunks)
- app/views/pages/_header.html.erb (1 hunks)
Files skipped from review due to trivial changes (1)
- app/views/pages/_header.html.erb
Additional Context Used
LanguageTool (25)
.controlplane/readme.md (5)
Near line 33: Possible missing comma found.
Context: ...cpln login
to ensure access. For more informatation check out the [docs here](https://shaka...
Near line 56: Loose punctuation mark.
Context: ...ontrolplanedirectory. 1.
/templates: defines the objects created with the
c...
Near line 58: Loose punctuation mark.
Context: ...n applycommand. 2.
/controlplane.yml`: defines your application, including the...
Near line 59: Loose punctuation mark.
Context: ... location, and app name. 3.Dockerfile
: defines the Docker image used to run th...
Near line 60: Loose punctuation mark.
Context: ...app on Control Plane. 4.entrypoint.sh
: defines the entrypoint script used to r...README.md (20)
Near line 14: Style-wise, it’s not ideal to insert an adverb (‘easily’) in the middle of an infinitive construction (‘to deploy’). Try moving the adverb to avoid split infinitives.
Context: ....md](./.controlplane/readme.md) for how to easily deploy this app to Control Plane. The instructions lev...
Near line 27: Some style guides suggest that commas should set off the year in a month-day-year date.
Context: ..., Written by Paul Benigeri, October 12, 2018](https://github.com/shakacode/react_on_...
Near line 33: Possible missing comma found.
Context: ...ebpack v5+ and Shakapacker for React on Rails including code splitting with loadable-...
Near line 80: Possible typo: you repeated a word
Context: ...line) + Javascript Development without Rails + Rails Integration + [Web...
Near line 99: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...om/smarter-css-builds-with-webpack/). - Example of enabling hot reloading of both JS an...
Near line 99: You might be missing the article “the” here.
Context: ...velopment mode. Change your code. Save. Browser updates without a refresh! - Example of...
Near line 102: The usual collocation for “independently” is “of”, not “from”. Did you mean “independently of”?
Context: .... - Enabling development of a JS client independently from Rails using the [Webpack Dev Server](ht...
Near line 104: ‘brand new’ seems to be a compound adjective before a noun. Use a hyphen: “brand-new”.
Context: ...an existing Rails app. You don't need a brand new single page app! - Example setting up R...
Near line 104: A punctuation mark might be missing here.
Context: ... app. You don't need a brand new single page app! - Example setting up Ruby and Java...
Near line 120: Possible typo: you repeated a word
Context: ... with plain HTML 1. Heroku for Rails 7 deployment 1. [Deployment to the ControlPlane](.controlplane/read...
Near line 131: The operating system from Apple is written “macOS”.
Context: ...which redis-server
. If missing and on MacOS, install with Homebrew (`brew install r...
Near line 161: Unpaired symbol: ‘]’ seems to be missing
Context: ...pp your-app ``` ## Testing + See [Yak Shaving Failing Integration Tests wi...
Near line 165: Consider a shorter alternative to avoid wordiness.
Context: ...to runforeman start -f Procfile.spec
in order to have webpack automatically recompile th...
Near line 165: Consider shortening this phrase to just ‘whether’, unless you mean ‘regardless of whether’.
Context: ...ec is configured to automatically check whether or not this process is running. If it is not, ...
Near line 184: After the expression ‘for example’ a comma is usually used.
Context: ...s a great way to learn about this! For example in [client/app/bundles/comments/compone...
Near line 203: A comma might be missing here.
Context: ...SASS The tutorial makes use of a custom font OpenSans-Light. We're doing this to sho...
Near line 210: Loose punctuation mark.
Context: ...> ``` 1.Procfile.dev
: Starts the Webpack Dev Server and Rails...
Near line 211: Loose punctuation mark.
Context: ...Procfile.static
: Starts the Rails server and generates s...
Near line 214: Possible typo: you repeated a word
Context: ...](https://github.com/justin808/), along with with many others. See [contributors.md](docs...
Near line 225: Insert a comma after thanking someone.
Context: ...bout/index.html#work-with-us). --- ## Thank you from Justin Gordon and [ShakaCode](http...
Additional comments not posted (3)
.controlplane/readme.md (2)
24-24
: URL update for Control Plane account setup looks good.
34-34
: URL update for Control Plane documentation looks good.README.md (1)
10-10
: URL update for Control Plane looks good.
This change is
Summary by CodeRabbit
Documentation
controlplane.com
toshakacode.controlplane.com
for account setup and documentation links.Style
shakacode.controlplane.com
.