-
Notifications
You must be signed in to change notification settings - Fork 2
Upgrade from Webpacker 3 to Shakapacker 7 and React-Rails 3 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
9aa9558
Upgrade webpacker to version 4.0.0
ahangarha 70e8944
Update files and js packages to match Webpacker 4 req
ahangarha 322861a
Add nvmrc
ahangarha 25ef38a
Upgrade Webpacker to v5.0.0
ahangarha d6428ae
Update files and js packages to match Webpacker req
ahangarha 48326da
Upgrade Webpacker to v5.4.4
ahangarha ff5d04e
Update files and js packages to match Webpacker req
ahangarha 23ab422
Upgrade Webpacker to 6.0.0.rc.6
ahangarha 48f7786
Update packages and set react-rails to 2.6.2
ahangarha 347eafb
Update files based on Webpacker version
ahangarha 1e2659e
Change Webpacker to Shakapacker 6.0.0
ahangarha 54915f2
Install peer dependencies
ahangarha e3c7de6
Rename binstubs from webpack to webpacker
ahangarha d8c7bfc
Update js files and config to match Shakapacker
ahangarha 1eab234
Upgrade Shakapcaker to 6.6.0
ahangarha cc0fabc
Upgrade to react-rails 2.7.1
ahangarha 4df48ae
Update js files related to webpack config
ahangarha 49a4a32
Install babel plugin
ahangarha 52f4470
Update bundler
ahangarha e5d2acc
Upgrade Shakapacker to version 7.0.2
ahangarha 3a8fbf5
Update spelling and formatting based on SP7
ahangarha b3fed47
Upgrade to React-Rails 3.0.0.rc.0
ahangarha 79c09c8
Clean up duplicates and outdated code
ahangarha cb7d90d
Remove redundant comment
ahangarha 612294b
Add newline at the end of all webpack config files
ahangarha 1199ea1
Remove .nvmrc
ahangarha 5d1aa6b
Update RR to 3.1.x
ahangarha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,8 @@ | |
|
||
/node_modules | ||
/yarn-error.log | ||
yarn-debug.log* | ||
.yarn-integrity | ||
|
||
.byebug_history | ||
/public/packs | ||
|
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v6?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in one PR?
I thought Upgrading Rails could and should have its own PR. And this little change was to make it possible to build the project. I don't remember now but there was an issue with Rails < 5.2. I couldn't run the app.