Add ToSql / FromSql for IpInet and IpCidr from cidr crate #877
Conversation
postgres-types/src/cidr_02.rs
Outdated
| fn from_sql(_: &Type, raw: &[u8]) -> Result<Self, Box<dyn Error + Sync + Send>> { | ||
| let inet = types::inet_from_sql(raw)?; | ||
| Ok(IpCidr::new(inet.addr(), inet.netmask()) | ||
| .expect("postgres cidr type has zeroed host portion")) |
There was a problem hiding this comment.
Why panic here instead of returning an error?
There was a problem hiding this comment.
the type only accepts postgres cidr type which postgres guarantees to be a valid cidr (i.e. mask length within the limits for the address type and zeroed host portion) which is the same as the requirements to create an IpCidr.
There was a problem hiding this comment.
If you assume the value passed to from_sql is always correct, then there's no need for any of these implementations to return an error. The library should not assume that the input is valid.
postgres-types/src/cidr_02.rs
Outdated
| fn from_sql(_: &Type, raw: &[u8]) -> Result<Self, Box<dyn Error + Sync + Send>> { | ||
| let inet = types::inet_from_sql(raw)?; | ||
| Ok(IpInet::new(inet.addr(), inet.netmask()) | ||
| .expect("postgres enforces maximum length of netmask")) |
There was a problem hiding this comment.
Similar, postgres guarantees that the inet type has a mask length corresponding to the address type (<= 32 for IPv4, <=128 for IPv6)
|
Thanks! |
No description provided.