Oid is unsigned

[jeff-davis]

I could submit a one-character patch if needed ;-)

[sfackler]

The message protocol docs seem to imply that it's signed, though they may just be playing it a bit fast and loose with the definition of "Int32": http://www.postgresql.org/docs/9.3/static/protocol-message-formats.html under ParameterDescription or RowDescription and http://www.postgresql.org/docs/9.3/static/protocol-message-types.html

[jeff-davis]

The backend uses unsigned integers for Oid; there's a pretty clear typedef. And it reads into that unsigned type in getParamDescriptions.

I don't have a good explanation for the docs. I sent a mail to the lists here:

http://www.postgresql.org/message-id/1388686291.19125.437.camel@jdavis

But in the meantime, an Oid type is certainly unsigned in the server and at the SQL level:

select 4000000000::oid

works.

[sfackler]

Interesting. There are probably some other parts of the message protocol that should be unsigned as well.

[jeff-davis]

http://www.postgresql.org/message-id/1381.1388688071@sss.pgh.pa.us

Confirmed -- more of a doc issue. I will probably try to make a doc patch.

Rust-postgres should be using a u32 for Oid though.