Skip to content

Bump MSRV to 1.56 #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Bump MSRV to 1.56 #315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d82a1f9
Adjust phf version requirement
GPHemsley Dec 9, 2022
71a64eb
Bump MSRV to 1.56
GPHemsley Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- nightly
- beta
- stable
- 1.40.0
- 1.56.0
features:
-
- --features dummy_match_byte
Expand All @@ -35,10 +35,6 @@ jobs:
toolchain: ${{ matrix.toolchain }}
override: true

- name: Downgrade phf to a version compatible with the MSRV
run: cargo update --package phf --precise 0.10.1
if: matrix.toolchain == '1.40.0'

- name: Cargo build
run: cargo build ${{ matrix.features }}

Expand Down
3 changes: 2 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ keywords = ["css", "syntax", "parser"]
license = "MPL-2.0"
build = "build.rs"
edition = "2018"
rust-version = "1.56"

exclude = ["src/css-parsing-tests/**", "src/big-data-url.css"]

Expand All @@ -24,7 +25,7 @@ cssparser-macros = {path = "./macros", version = "0.6"}
dtoa-short = "0.3"
itoa = "1.0"
matches = "0.1"
phf = {version = ">=0.8,<=0.11", features = ["macros"]}
phf = {version = "~0.9", features = ["macros"]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping seems fine, but can we just use 0.11 here now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phf 0.11 has an MSRV of 1.60.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, we can have the lockfile with 0.10 or so.

serde = {version = "1.0", optional = true}
smallvec = "1.0"

Expand Down