Handle undefined function package.exclude #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using a service with the package rules:
and then re-including that for only one of the functions to keep the package sizes down with:
Currently, when I do that I get the error
Cannot read property 'Symbol(Symbol.iterator)' of undefined
because theprepare
function only sets defaults forpackage
if it does not exist at all, and doesn't check that it has bothinclude
andexclude
.My workaround for that has been to add an arbitrary path to exclude, but I added a default empty array here in case
exclude
is undefined. Let me know if there's anything you'd like me to update on this!