Skip to content

Fix issue #219 #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fix issue #219 #282

merged 1 commit into from
Oct 5, 2022

Conversation

douwe-rm
Copy link
Contributor

@douwe-rm douwe-rm commented Oct 5, 2022

Fixes #219. This fix replaces fs.unlinkSync with fs.removeSync, as fs.removeSync should not be used on directories (such as 'node_modules').

This solves issues that can occur when running sls deploy.

Copy link
Contributor

@medikoo medikoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@medikoo medikoo added the bug label Oct 5, 2022
@medikoo medikoo merged commit a1098de into serverless:master Oct 5, 2022
@ThallesP
Copy link

ThallesP commented Oct 6, 2022

hey @medikoo any chance of releasing this fix on NPM? my builds are failing because of this

@medikoo
Copy link
Contributor

medikoo commented Oct 6, 2022

@ThallesP released as v2.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPERM: operation not permitted, unlink '.../.build/node_modules'
3 participants