Add in package/includes to final build product. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also locked in fs-p to 2.0.0 because I was getting build errors. |
schickling
reviewed
May 22, 2017
src/index.ts
Outdated
| @@ -53,6 +55,21 @@ class ServerlessPlugin { | |||
|
|
|||
| // include node_modules into build | |||
| fs.symlinkSync(path.resolve('node_modules'), path.resolve(path.join(buildFolder, 'node_modules'))) | |||
| // include any "extras" from the "include" section | |||
| if(this.serverless.service.package.include && this.serverless.service.package.include.length > 0){ | |||
| globby(this.serverless.service.package.include).then((files) => { | |||
There was a problem hiding this comment.
Please use async & await here.
src/index.ts
Outdated
| if(this.serverless.service.package.include && this.serverless.service.package.include.length > 0){ | ||
| globby(this.serverless.service.package.include).then((files) => { | ||
| _.forEach(files, (filename) => { | ||
| let destFileName = path.resolve(path.join(buildFolder, filename)); |
There was a problem hiding this comment.
Any reason not to use const instead of let?
src/index.ts
Outdated
| _.forEach(files, (filename) => { | ||
| let destFileName = path.resolve(path.join(buildFolder, filename)); | ||
| let dirname = path.dirname(destFileName); | ||
| if(!fs.existsSync(dirname)){ |
There was a problem hiding this comment.
Please use spaces like so: if (!fs.existsSync(dirname)) {
(Also applies to other places)
|
I've added a few comments. Would be great if you could adust it :) |
Other minor style updates suggested by @schickling
|
No problem, sorry I haven't been writing in TypeScript that long and I only recently learned of Async/Await. Does this look better? |
|
Looks great now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9