Skip to content

removed trailing comma in compile functions js #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2018
Merged

removed trailing comma in compile functions js #137

merged 1 commit into from
Nov 28, 2018

Conversation

lczmdr
Copy link

@lczmdr lczmdr commented Nov 27, 2018

Issue related #110

@erikerikson
Copy link
Contributor

Thanks for offering this fix. I'm confused how this is different from:
#118

Clearly it is... I'm guessing another PR introduced this..
Perhaps add to the unit tests to catch future instances of these errors?

@pmuens ^

pmuens
pmuens approved these changes Nov 28, 2018
View reviewed changes
Copy link
Contributor

@pmuens pmuens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting 🤔

Thanks for pinging @erikerikson and thanks for fixing @lczmdr 👍

Looks like this is rather hard to cover via unit tests. I'll merge this in since we've already mergeg #118 which also lacks a unit test case.

@pmuens pmuens merged commit e16a09b into serverless:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmuens pmuens pmuens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lczmdr @erikerikson @pmuens