Skip to content

feat: add multiple custom templates #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lxhunter
Copy link
Contributor

@lxhunter lxhunter commented Nov 6, 2024

Hey Guys,

i needed to implement custom templates for different status codes.

As I did not contribute a lot to open source projects before, please go easy on me ;)

I added tests, added documentation and build the functionality so that i does not break backwards compatibility.

Please let me know if i should change anything.

May the love be with you,
Lx

@horike37
Copy link
Collaborator

horike37 commented Nov 6, 2024

@lxhunter
Thank you for your contribution! That's a good functionality for this plugin.
But Some linting errors happen. which are coding rules you have to follow. Would you check and fix them?

@lxhunter
Copy link
Contributor Author

lxhunter commented Nov 6, 2024

@horike37
I fixed the linting errors, but still have an error regarding the reponseParameters left to fix.
I will fix it tomorrow and get back to you!

Thanks for the fast feedback

@lxhunter
Copy link
Contributor Author

@horike37 so the work and testing is done, please have a look and tell me if it is okay.

OFFTOPIC: would you be interested, that i merge the functionality from my plugin (https://github.com/the-fittest/serverless-step-function-sync) into this one?

@zirkelc
Copy link
Collaborator

zirkelc commented May 1, 2025

Hey @lxhunter it's been some time since the last comment, is the PR ready to be merged or have you found something other to be addressed?

@lxhunter
Copy link
Contributor Author

lxhunter commented May 1, 2025

I think it is goat!

@zirkelc zirkelc merged commit 6e9847b into serverless-operations:master May 3, 2025
@zirkelc
Copy link
Collaborator

zirkelc commented May 8, 2025

🎉 This PR is included in version 3.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants