Skip to content

feat: support custom state machine names when using a distributed mapA #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

toddhainsworth
Copy link
Contributor

Fixes #543 by looking for a 'name' field on the state machine and falling back to using it's ID if no name is provided.

@toddhainsworth
Copy link
Contributor Author

Hey @lopburny is there any chance this could be reviewed and included in the next release? This bug is currently blocking some current and upcoming work for us.

Copy link
Contributor

@akshaydk akshaydk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddhainsworth
Copy link
Contributor Author

Hey @akshaydk do you happen to know when the next release is planned? Keen to upgrade to unblock a bunch of work we're doing 🙏

@akshaydk
Copy link
Contributor

akshaydk commented Mar 2, 2023

@toddhainsworth I'm sorry. I just a contributor to this project.

@lopburny Can you take a look at this?

@lopburny
Copy link
Contributor

lopburny commented Mar 8, 2023

@toddhainsworth @akshaydk Thank you so much to you folks! All looks good to me👍

@lopburny lopburny merged commit 47fcb4e into serverless-operations:master Mar 8, 2023
@lopburny
Copy link
Contributor

lopburny commented Mar 8, 2023

🎉 This PR is included in version 3.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ss-betseqnzr pushed a commit to BetSEQNZR/serverless-step-functions that referenced this pull request Sep 8, 2023
…ure/distributed-map-custom-name

feat: support custom state machine names when using a distributed mapA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing IAM Role permissions for Distributed Map states
3 participants