-
Notifications
You must be signed in to change notification settings - Fork 216
feat: support the latest SFN ItemProcessor (replaces Iterator) #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @bahrmichael Thank you for this PR. Let me take a look just in case and I'll update you soon🙌 |
I ran into this same issue. Thanks @bahrmichael for getting this started. After a bit more digging, it appears the Iterator state is now deprecated
When i generate a new step function i just copy paste the generated code from the aws console. Since they use the newer
to
That being said, it would be nice to get this merged as eventually this workaround will not work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you can squash your commits
@j0k3r Done! Do you think the tests are sufficient? I'm not sure how I can test this plugin locally. |
@bahrmichael at least it's seems ok to me! :) |
Awesome! I'll be the first to use it once it's merged :) |
@lopburny Could I get your eyes on this again? |
Thank you @bahrmichael @j0k3r , All look good to me👍 |
🎉 This PR is included in version 3.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
feat: support the latest SFN ItemProcessor (replaces Iterator)
When building a new step function I noticed that what was previously the
Iterator
has been changed toItemProcessor
. Probably changed with reinvent and their release of Distributed Maps. Here's an example of a state machine that I built with their visual builder and then adjusted to reference my functions: https://github.com/bahrmichael/trade-game-backend/pull/50/commits/9a75d378d7e67673bffc448f5507793c2eb9408e#diff-ea2dbe8c0992878214f1020b0c7ee79668dc63b5c8325a5ed67892d0080a9b27When setting
validate: true
I noticed that the plugin expects anIterator
within aMap
task, which fails with the newItemProcessor
: https://github.com/bahrmichael/trade-game-backend/actions/runs/3633513042/jobs/6130610217This PR shows how far I've gotten, but there seems to be another error where I'm not sure if merging this PR already would cause problems for other folks: https://github.com/bahrmichael/trade-game-backend/actions/runs/3633603701/jobs/6130803277
Let me know what you think! I'm not confident that the test is sufficient, please give me a pointer on what it should also test.