feat: added Fn::Join to ARN deployment schemas #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clayzermk1 it looks good, but can you reopen the PR and make sure your commit messages follow [conventional commits] (https://www.conventionalcommits.org/en/v1.0.0) format? The message should look something like |
|
Also, can you have a look at the style errors that are breaking the build? |
|
No problemo, sorry about that. I should have read the contributing docs first. |
clayzermk1
force-pushed
the
alarm-notification-fnjoin
branch
from
6c4da2b to
7be54b2
Compare
|
All updated. |
clayzermk1
changed the title
|
🎉 This PR is included in version 2.29.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks for the merge and quick release! |
ss-betseqnzr
pushed a commit
to BetSEQNZR/serverless-step-functions
that referenced
this pull request
Sep 8, 2023
…tification-fnjoin feat: added Fn::Join to ARN deployment schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I found myself wanting to be able to use the
Fn::JoinCloudFormation pseudo parameter function and noticed that it was being rejected by validation. After adding it to the ARN deploy schemas, it seems to work fine - resources are created as expected.I have only tested alarms and notifications, however I added it to the state machines schema as well for consistency.
What do you think about allowing
Fn::Jointo the validation schemas? I'm more than happy to make any changes you'd like to the code.Cheers, and thank you for the useful plugin!