Skip to content

feat(codebuild): add IAM policy statement generation for codebuild #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions lib/deploy/stepFunctions/compileIamRole.js
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,28 @@ function getStepFunctionsPermissions(state) {
}];
}

function getCodeBuildPermissions(state) {
const projectName = state.Parameters.ProjectName;

return [{
action: 'codebuild:StartBuild,codebuild:StopBuild,codebuild:BatchGetBuilds',
resource: {
'Fn::Sub': [
`arn:aws:codebuild:$\{AWS::Region}:$\{AWS::AccountId}:project/${projectName}`,
{},
],
},
}, {
action: 'events:PutTargets,events:PutRule,events:DescribeRule',
resource: {
'Fn::Sub': [
'arn:aws:events:${AWS::Region}:${AWS::AccountId}:rule/StepFunctionsGetEventForCodeBuildStartBuildRule',
{},
],
},
}];
}

// if there are multiple permissions with the same action, then collapsed them into one
// permission instead, and collect the resources into an array
function consolidatePermissionsByAction(permissions) {
Expand Down Expand Up @@ -344,6 +366,10 @@ function getIamPermissions(taskStates) {
case 'arn:aws:states:::states:startExecution.waitForTaskToken':
return getStepFunctionsPermissions(state);

case 'arn:aws:states:::codebuild:startBuild':
case 'arn:aws:states:::codebuild:startBuild.sync':
return getCodeBuildPermissions(state);

default:
if (isIntrinsic(state.Resource) || state.Resource.startsWith('arn:aws:lambda')) {
const trimmedArn = trimAliasFromLambdaArn(state.Resource);
Expand Down
58 changes: 57 additions & 1 deletion lib/deploy/stepFunctions/compileIamRole.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1560,6 +1560,63 @@ describe('#compileIamRole', () => {
expectation(policy2, lambdaArns[2], lambdaArns[3]);
});

it('should give CodeBuild permissions', () => {
const projectName = 'HelloProject';
const genStateMachine = id => ({
id,
definition: {
StartAt: 'A',
States: {
A: {
Type: 'Task',
Resource: 'arn:aws:states:::codebuild:startBuild',
Parameters: {
ProjectName: projectName,
},
Next: 'B',
},
B: {
Type: 'Task',
Resource: 'arn:aws:states:::codebuild:startBuild.sync',
Parameters: {
ProjectName: projectName,
},
End: true,
},
},
},
});
serverless.service.stepFunctions = {
stateMachines: {
myStateMachine1: genStateMachine('StateMachine1'),
},
};

serverlessStepFunctions.compileIamRole();
const statements = serverlessStepFunctions.serverless.service
.provider.compiledCloudFormationTemplate.Resources.StateMachine1Role
.Properties.Policies[0].PolicyDocument.Statement;

const codeBuildPermissions = statements.filter(s => _.isEqual(s.Action, ['codebuild:StartBuild', 'codebuild:StopBuild', 'codebuild:BatchGetBuilds']));
expect(codeBuildPermissions).to.have.lengthOf(1);
expect(codeBuildPermissions[0].Resource).to.deep.eq([{
'Fn::Sub': [
`arn:aws:codebuild:$\{AWS::Region}:$\{AWS::AccountId}:project/${projectName}`,
{},
],
}]);


const eventPermissions = statements.filter(s => _.isEqual(s.Action, ['events:PutTargets', 'events:PutRule', 'events:DescribeRule']));
expect(eventPermissions).to.have.lengthOf(1);
expect(eventPermissions[0].Resource).to.deep.eq([{
'Fn::Sub': [
'arn:aws:events:${AWS::Region}:${AWS::AccountId}:rule/StepFunctionsGetEventForCodeBuildStartBuildRule',
{},
],
}]);
});

it('should give step functions permissions (too permissive, but mirrors console behaviour)', () => {
const stateMachineArn = 'arn:aws:states:us-east-1:123456789:stateMachine:HelloStateMachine';
const genStateMachine = id => ({
Expand Down Expand Up @@ -1935,7 +1992,6 @@ describe('#compileIamRole', () => {
.Properties.Policies[0].PolicyDocument.Statement;
const lambdaPermissions2 = statements2.filter(s => _.isEqual(s.Action, ['lambda:InvokeFunction']));
expect(lambdaPermissions2).to.have.lengthOf(1);
console.log(lambdaPermissions2);
expect(lambdaPermissions2[0].Resource).to.deep.equal([
'arn:aws:lambda:us-west-2:1234567890:function:foo',
'*limited*',
Expand Down