Skip to content

Fix SQS QueueUrl transformation to ARN when intrinsic function being passed in #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

FilipPyrek
Copy link
Contributor

Should solve: #253

I got an idea that maybe it would be nice if we could set QueueArn in State Machine definition like this:

some-step:
  Type: Task
  Resource: arn:aws:states:::sqs:sendMessage.waitForTaskToken
  Parameters:
    QueueUrl: { "Fn::ImportValue": "some-queue-url" }
    QueueArn: { "Fn::ImportValue": "some-queue-arn" }
    Message: "42"
  End: true

But I wasn't sure how this would fit to architecture of whole project.

@theburningmonk
Copy link
Collaborator

Doesn't look like Step Functions supports QueueARN for the SQS integration. If you did that, you'd have to translate the ARN into a queue URL. I'm not seeing the value of that, got any use case in mind?

}
// in case of for example { Fn::ImportValue: sharedValueToImport }
// we need to use "*" as ARN
return '*';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, now I see why you want to add both QueueUrl as well as QueueArn, so you can ref the Arn in the IAM instead of QueueUrl. It'd be doable for sure, but it'd be a bit odd though, and hard to explain to people. Let's leave it as it is for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's what I meant. I agree with you. 🙂 👍

Copy link
Collaborator

@theburningmonk theburningmonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theburningmonk theburningmonk merged commit 5dd8e54 into serverless-operations:master Oct 1, 2019
@theburningmonk
Copy link
Collaborator

🎉 This PR is included in version 2.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

ss-betseqnzr pushed a commit to BetSEQNZR/serverless-step-functions that referenced this pull request Sep 8, 2023
…aster

Fix SQS QueueUrl transformation to ARN when intrinsic function being passed in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants