Closes #130 Shared API Gateway and maxAge property support for HTTP Endpoints #131
Conversation
|
@horike37 All tests are green but coveralls seems to be unhappy |
|
@horike37 All green! |
|
@vlewin |
|
@horike37 Yes you can. We tested my changes already with production code and everything seems to be fine. |
There was a problem hiding this comment.
Hi @vlewin
I just tested and reviewed the code and great to see working fine as expected 👍 💯
However, maxAge doesn't work. Maybe this isn't needed for share api configuration.
Either way is fine to me.
- Remove the code for maxAge from this PR
- Fix on this PR
What do you want to do? 😄
We will merge it just after maxAge problem will be resolved!
| @@ -24,6 +25,16 @@ module.exports = { | |||
| 'Access-Control-Allow-Credentials': `'${config.allowCredentials}'`, | |||
| }; | |||
|
|
|||
| // Enable CORS Max Age usage if set | |||
| if (_.has(config, 'maxAge')) { | |||
There was a problem hiding this comment.
Seems that maxAge option doesn't work.
There was a problem hiding this comment.
@horike37 Good catch! maxAge property issue is fixed.
There was a problem hiding this comment.
cloudformation-template-update-stack.json
API Gateway Integration Response
horike37
changed the title
|
@vlewin |
|
@horike37 Thank you for accepting and awesome plugin! |
|
Great work @vlewin You are Rock!!! |
Closes serverless-operations#130 Shared API Gateway and maxAge property support for HTTP Endpoints
Closes #130 Shared API Gateway support for HTTP Endpoints