Support custom logicalId separate from name #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be better to just use the key as the logical id, but this is more backwards-compatible.
This allows specifying an id that is different than the name. This makes it more deterministic for purposes of Ref, etc.
In fact, where
key
means the stateMachines key for a given state machine, I think making the name default to "{service}-{key}-{stage}" and the logicalId to{Key}StepFunctionStateMachine
is a very sensible default.