Skip to content

Populating object before parsing step function #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

lucas-rudd
Copy link
Contributor

Currently this plugin is setting the step function, state machine, and activity keys before the serverless.yml file has populated the variables.

This allows you to organize serverless.yml like such:

stepFunctions:
  stateMachines:
    ${file(config/env/${opt:stage}.yml):stateMachines}

but not like this

stepFunctions:
  ${file(config/env/${opt:stage}.yml):stepFunctions}

This proposed change populates the variables before determining whether or not a step function exists in the given config.

Copy link
Collaborator

@horike37 horike37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucas-rudd
Works great!
LGTM 😄

@horike37 horike37 merged commit e44d8ef into serverless-operations:master Apr 24, 2018
ss-betseqnzr pushed a commit to BetSEQNZR/serverless-step-functions that referenced this pull request Sep 8, 2023
…ObjectBeforeParsingStepFunction

Populating object before parsing step function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants