Skip to content

fix: incorrect function name #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2020

Conversation

rphelan
Copy link
Contributor

@rphelan rphelan commented Jul 24, 2020

When the number of lambda function versions exceeds 50, the method getlatestVersionLambdaArn must recursively fetch one or more additional pages of results. The recursive function call does not match the name of the parent function resulting in:

TypeError: this.getlatestVersion is not a function at ServerlessLambdaEdgePreExistingCloudFront.getlatestVersionLambdaArn (index.js:124:25)

This PR updates the function name to match.

@o-alexandrov
Copy link

o-alexandrov commented Jul 28, 2020

Please let us know what prohibits this PR from being merged?
In the meantime, for anyone who stumbles upon it, just set in dependency list of your package.json:

"serverless-lambda-edge-pre-existing-cloudfront": "rphelan/serverless-lambda-edge-pre-existing-cloudfront",

Copy link
Contributor

@horike37 horike37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I missed this PR.
LGTM! Thanks!

@horike37 horike37 merged commit 5753b27 into serverless-operations:master Aug 22, 2020
@horike37
Copy link
Contributor

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants