Skip to content

Support Fn::ImportValue as distribution id #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 30, 2021
Merged

Support Fn::ImportValue as distribution id #20

merged 5 commits into from
Sep 30, 2021

Conversation

mordka
Copy link
Contributor

@mordka mordka commented Dec 9, 2020

This PR adds support for distribution id specified as an intrinsic function Fn::ImportValue
Example:

      - preExistingCloudFront:
          distributionId:
            'Fn::ImportValue': 'CloudFront-SomeDistribution::CloudFrontID'

Currently this is not supported and the following error is returned upon deploy

Expected params.Id to be a string

@flonn
Copy link

flonn commented Apr 19, 2021

As a workaround, @jgrumboe discovered that using outputs instead of exports work. https://www.serverless.com/framework/docs/providers/aws/guide/variables/#referencing-environment-variables

@brianantonelli
Copy link

Any chance of merging this down?

@horike37 horike37 merged commit ed639ec into serverless-operations:master Sep 30, 2021
@horike37
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mordka @flonn @brianantonelli @horike37