Skip to content

Add missing input.name parameter for evaluation of config.name #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

KowalskiTom
Copy link

Add missing input.name parameter for evaluation of config.name

@laardee
Copy link
Contributor

laardee commented Nov 18, 2019

@KowalskiTom should the role be named with the same name than the lambda? After your role PR is merged, this could contain also a role name.

Otherwise seems to work as expected.

@KowalskiTom
Copy link
Author

@laardee good call. I have added this in.

@KowalskiTom KowalskiTom reopened this Nov 22, 2019
@KowalskiTom KowalskiTom changed the title Update serverless.js Add missing input.name parameter for evaluation of config.name Nov 22, 2019
@Podders
Copy link

Podders commented Jan 29, 2020

@eahefnawy any plans to merge this one? It's kind of a needed option in my humble opinion

@nathanmargaglio
Copy link

What's stopping this from being merged? I'd be willing to help get this thing up ASAP

@SarKurd
Copy link

SarKurd commented Feb 28, 2020

@eahefnawy we desperately need this, could you please review?

@Belco90
Copy link

Belco90 commented Mar 5, 2020

Another one here needing this ✋

@JStein92
Copy link

JStein92 commented Mar 9, 2020

@eahefnawy we need this as well.

@watanabeyu
Copy link

@eahefnawy please merge

@falecci-morean
Copy link

Need this as well :)

@eahefnawy
Copy link
Member

Thanks all! We rebuilt the entire thing from scratch and updated it for Components V2 and incorporated this change.

@eahefnawy eahefnawy closed this Apr 9, 2020
@andidev
Copy link

andidev commented Apr 13, 2020

@eahefnawy
When is this released?

@eahefnawy
Copy link
Member

It's already out. Check out the readme:
https://github.com/serverless-components/aws-lambda/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.