Skip to content

failCommentCondition isnt checked for "success" step #1025

Open
@rhys-childs

Description

@rhys-childs

failComment is marked as deprecated, but failCommentCondition isn't actually checked in the success step like failComment was.

failCommentCondition was added to the config here

The deprecation warning was added to the fail step for failComment here

But the same check is not performed here

The result is that you have to use the deprecated failComment config value to disable issue checking on the success step.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions