Skip to content

Fix the "show_notes" feature of SeleniumBase Presenter #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 1, 2020
Merged

Fix the "show_notes" feature of SeleniumBase Presenter #606

merged 8 commits into from
Jul 1, 2020

Conversation

mdmintz
Copy link
Member

@mdmintz mdmintz commented Jul 1, 2020

Fix the "show_notes" feature of SeleniumBase Presenter

  • Fix Presenter "show_notes" and move arg to different area
  • Include requirements.txt with "sbase mkdir DIR"
  • Update a Python dependency (rich==3.0.1)

Updated Methods:

self.create_presentation(name=None, theme="default")

self.add_slide(content=None, image=None, code=None, iframe=None,
               content2=None, notes=None, name=None)

self.save_presentation(name=None, filename=None, show_notes=True, interval=0)

self.begin_presentation(name=None, filename=None, show_notes=True, interval=0)

@hiqqs
Copy link
Contributor

hiqqs commented Jul 1, 2020

🚀 🚀 🚀 🚀

hiqqs
hiqqs reviewed Jul 1, 2020
View reviewed changes
help_docs/method_summary.md

self.add_slide(content=None, image=None, code=None, iframe=None,
content2=None, notes=None, name=None)

self.save_presentation(name=None, filename=None, interval=0)
self.save_presentation(name=None, filename=None, show_notes=True, interval=0)
Copy link
Contributor

@hiqqs hiqqs Jul 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this hardcode showNotes to true on save? should be None? maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooooo nvm i see its just the help docs 👍

@mdmintz mdmintz merged commit 0dad07d into master Jul 1, 2020
@mdmintz mdmintz deleted the fix-presenter-notes branch July 1, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiqqs hiqqs hiqqs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdmintz @hiqqs