Skip to content

UC Mode's driver.uc_click(selector) isn't properly escaping selectors that contain quotes #2666

Closed
@mdmintz

Description

@mdmintz

UC Mode's driver.uc_click(selector) isn't properly escaping selectors that contain quotes


This can lead to:
selenium.common.exceptions.JavascriptException: Message: javascript error: missing ) after argument list.

To reproduce, try using a selector such as button[type="submit"] during driver.uc_click(selector) (Because that leads to this if the quotes aren't escaped: document.querySelector("button[type="submit"]").click();, which is invalid because double quotes are being used inside of other double quotes.)

Metadata

Metadata

Assignees

Labels

UC Mode / CDP ModeUndetected Chromedriver Mode / CDP ModebugUh oh... Something needs to be fixed

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions