Improve measureString performance #1199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create only once a <span> element and use it to measure string. Remove element if Selectize.count equal 0.
|
@joallard this is the PR which improve measureString performances integrated in the main source. |
|
Any chance to merge this PR in a short time? @joallard |
joallard
reviewed
Jan 25, 2017
| @@ -2049,6 +2049,11 @@ $.extend(Selectize.prototype, { | |||
| self.$control_input.removeData('grow'); | |||
| self.$input.removeData('selectize'); | |||
|
|
|||
| if (--Selectize.count == 0 && Selectize.$testInput) { | |||
There was a problem hiding this comment.
What this condition does is not immediatly clear
There was a problem hiding this comment.
Can you break this out in a better descriptively named function?
There was a problem hiding this comment.
Yeah, I can break into a function and give some benchmarks in a couple of days.
|
Do you have benchmark stats? |
michael-maltsev
pushed a commit
to michael-maltsev/selectize.js
that referenced
this pull request
Aug 28, 2018
Improve measureString performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create only once a element and use it to measure string.
Remove element if Selectize.count equal 0.