-
Notifications
You must be signed in to change notification settings - Fork 27
Allow any class names to be exported #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe add a test that uses a hyphen for a class name? ie. 'Class--Name' |
@silbinarywolf good point, idk why I haven't thought of it myself :( |
This stylesheet still gives problems:
->
|
Hey Bud, This is a nice solution to the problem, thanks for working this out. Can you just remove the " |
@stephankaag Your issue is unrelated to this one as it's broken with both approaches. Feel free to submit a separate PR to resolve it. |
@MattsJones I'm on it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
Going to release as a new major to let users opt into the new declaration template. Versions are cheap 💸
This change allows any possible class name to be exported - even those whose names don't comply with typescript variable name constraints.
Addresses problem from issue #6.