Skip to content

hsfz: Fix acknowledgment transfer packet structure. #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

antoniovazquezblanco
Copy link
Contributor

Checklist:

  • If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • I squashed commits belonging together
  • I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

Fixes ACK packet structure in HSFZ.

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.16%. Comparing base (6c658dd) to head (86235ec).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4758      +/-   ##
==========================================
+ Coverage   79.52%   82.16%   +2.64%     
==========================================
  Files         344      362      +18     
  Lines       87082    87359     +277     
==========================================
+ Hits        69251    71778    +2527     
+ Misses      17831    15581    -2250     
Files with missing lines Coverage Δ
scapy/contrib/automotive/bmw/hsfz.py 62.24% <100.00%> (+0.78%) ⬆️

... and 289 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@polybassa
Copy link
Contributor

Thanks for the PR!

@polybassa polybassa merged commit 0022dfd into secdev:master Jun 1, 2025
24 checks passed
@antoniovazquezblanco
Copy link
Contributor Author

Lovely, Thank you! :D

@antoniovazquezblanco antoniovazquezblanco deleted the hsfz2 branch June 1, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants